-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for async group chat #902
Conversation
@microsoft-github-policy-service agree company="Parker Hannifin" |
@qingyun-wu @sonichi @kittyandrew I made this to hopefully merge #543 so we can have async calls to OpenAI. |
Thanks! I will take a look at this soon. |
Could you run pre-commit to regulate code format? Thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
===========================================
+ Coverage 26.58% 37.35% +10.77%
===========================================
Files 28 28
Lines 3732 3732
Branches 847 889 +42
===========================================
+ Hits 992 1394 +402
+ Misses 2667 2197 -470
- Partials 73 141 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed code format issues. LGTM now! Thank!
I am very proud to be a contributor to such an important Microsoft repo! |
@qingyun-wu I have some very bad news. I just built autogen from source with the new merges and it is STILL not running async, at least for me. |
* Add test for async group chat * run pre-commit --------- Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
* Add test for async group chat * run pre-commit --------- Co-authored-by: Qingyun Wu <qingyun.wu@psu.edu>
Issue #543 has been on hold for 3 weeks, due to not having tests for groupchat. I added a test for groupchat, so hopefully now we can use AutoGen to call OpenAI asynchronously.